features: fix the CRS in a request body and the last modification time - #617
Merged
Conversation
- The 'coordRefSys' member of a geometry was passed to the parser as the enclosing object, so a JSON-FG geometry with an in-document coordinate reference system was rejected with "Expected STRING, OBJECT or ARRAY for 'coordRefSys', but got: OBJECT". - The JSON and the GML geometry decoder can be restricted to a list of coordinate reference systems; a 'coordRefSys' member or a 'srsName' attribute that resolves to another one is rejected. Only the code is compared, not the axis order, which is a property of the encoding. - The last modification time of a feature was parsed with Instant.parse in a catch-and-ignore, which fails for every value without a time zone - and a DATETIME property is projected as a timestamp without time zone. It is now parsed with the same flexible parser as the temporal extent, a value without a time zone is interpreted in the provider's 'nativeTimeZone', and a value that cannot be parsed at all is logged instead of ignored. - The source schema validator warns when a DATETIME property is mapped to a column with a time zone while 'nativeTimeZone' is set to another zone than UTC: the values of such a column are read in UTC and would then be interpreted in the configured zone, which shifts them.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of addressing ldproxy/ldproxy#1756
enclosing object, so a JSON-FG geometry with an in-document coordinate
reference system was rejected with "Expected STRING, OBJECT or ARRAY for
'coordRefSys', but got: OBJECT".
coordinate reference systems; a 'coordRefSys' member or a 'srsName'
attribute that resolves to another one is rejected. Only the code is
compared, not the axis order, which is a property of the encoding.
catch-and-ignore, which fails for every value without a time zone - and a
DATETIME property is projected as a timestamp without time zone. It is now
parsed with the same flexible parser as the temporal extent, a value
without a time zone is interpreted in the provider's 'nativeTimeZone', and
a value that cannot be parsed at all is logged instead of ignored.
column with a time zone while 'nativeTimeZone' is set to another zone than
UTC: the values of such a column are read in UTC and would then be
interpreted in the configured zone, which shifts them.