Refactor iso9660 module - #32
Draft
skr4n wants to merge 14 commits into
Draft
Conversation
Rearrange code to bring the `impl`s near the `struct`s, keeping things consistent with the rest of the code.
Rather than have an `xa` module, re-export everything within `xa` and other child modules at the level of the `iso9660` module, keeping things consistent with others like `mmc`.
skr4n
force-pushed
the
refactor-iso9660
branch
from
August 18, 2026 04:18
0823825 to
d7cedff
Compare
skr4n
force-pushed
the
refactor-iso9660
branch
from
August 18, 2026 07:59
d7cedff to
9b2365f
Compare
Studying the source of libcdio C, `IsoExtensions` seem to only be a soft switch to make the code ignore the said extensions in a given ISO 9660 filesystem. As such, it doesn't provide much use. `Iso::builder()` can also be removed, since `Iso` now accepts only one input parameter.
Contributor
|
As with the other PRs, I don't have a problem with the changes. But running the tests gives me time differences. We can merge all of the PRs and deal with the time zone issues as a separate problem. Your choice. |
Collaborator
Author
Sure. |
skr4n
force-pushed
the
refactor-iso9660
branch
from
August 19, 2026 05:01
9b2365f to
05f4010
Compare
skr4n
marked this pull request as draft
August 19, 2026 08:28
Collaborator
Author
|
Turned it into a draft. Need to rework some parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and other changes to make code consistent with the idioms and patterns used throughout the crate.
ResultoverOptionPlease refer to the commit messages for more information.