Refactor UDF module - #33
Open
skr4n wants to merge 8 commits into
Open
Conversation
Contributor
|
I don't have a problem with the code. When I run on Ubuntu, I am seeing the time differences that I'm seeing in the CI branch. (I realize though though that github's CI is fine with this.) |
skr4n
marked this pull request as draft
August 19, 2026 08:28
skr4n
force-pushed
the
refactor-udf
branch
3 times, most recently
from
August 20, 2026 13:45
8d6cca0 to
e256695
Compare
Avoid extra allocation when creating a CString from a Path. Instead, a PathBuf can reuse its existing allocation when converting into a CString.
Prevent an additional allocation from converting an `&str` to a `CString`.
skr4n
marked this pull request as ready for review
August 20, 2026 16:27
Collaborator
Author
|
I'll take care of merge conflicts (which should come after one of these is merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As always, refer to the commit messages for more info.