lib/iso9660: Get local offset based on input time - #35
Merged
Merged
Conversation
libcdio's time methods are cumbersome due to their dependence on non-standard `struct tm`. While commit `2c58e64` used `struct tm`'s `gmtoff` field for UTC offsets, commit `cc4c40a` moved this to a system call for portability. This was implemented in a way that queried the GMT offset based on the current time, rather than the input time, causing DST to not be accounted for. Fix by querying the offset at the input time, rather than current time.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcdio's time methods are cumbersome due to their dependence on non-standard
struct tm.While commit 2c58e64 used
struct tm'sgmtofffield for UTC offsets, commit cc4c40a moved this to a system call for portability. This was implemented in a way that queried the GMT offset based on the current time, rather than the input time, causing DST to not be accounted for.Fix by querying the offset at the input time, rather than current time.