made mouse move throttle configurable - #763
johanneszelger wants to merge 4 commits into
Conversation
|
|
89a8832 to
4ef934c
Compare
|
❌ Linting errors found These linting errors must be fixed before this PR can be merged: Run |
Test Results: ✅ PASSEDRun at: 2026-09-18T13:05:14.240Z Summary: |
michielvandergeest
left a comment
michielvandergeest
left a comment
There was a problem hiding this comment.
hey @johanneszelger, thanks for this PR! ❤️
Looks good, I left a small comment.
Also, we'll need the contributor licence agreement to be signed to move this one along. Thx
| // limit the amount of move events per time frame | ||
| mouseMoveHandler = (e) => { | ||
| if (e.timeStamp - lastMoved < 100) return | ||
| if (e.timeStamp - lastMoved < Settings.get('mouseMoveThrottle', 100)) return |
There was a problem hiding this comment.
can we move the Settings.get() method outside of this callback function, so we don't get the static session on every execution?
|
i did sign it, and i did add my github accounts email to the commits (that was the earlier force push). not sure why its not working? |
|
ok signed again, i think it worked now |
|
❌ Linting errors found These linting errors must be fixed before this PR can be merged: Run |
Test Results: ✅ PASSEDRun at: 2026-09-18T14:25:00.071Z Summary: |
|
nice! yeah CLA seems to be okay now 👍 would be great if you could address this comment here: #763 |
|
Hi Michiel, i fixed the linting and added another improvement that allows consumers to change the trottling at runtime, for example during a fullscreen animation. Not sure if this is something you are happy to do, if not, i can revert the commit. |
3 participants
mouse move throttle was a fixed 100ms, can now be configurate.
motivation: for some screens such as a login screen with a custom keyboard, 100ms can feel unresponsive.