emit a textCalculated before a text might actually be loaded.

[jfboeve]

No description provided.

[Copilot]

🟡 Changes recommended

Preserve layout invalidation when textCalculated listeners modify layout properties.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a synchronous textCalculated event before the deferred text-loaded event.

Changes:

• Simplifies TextConstraint enum syntax.
• Emits calculated text dimensions earlier.

A moderate issue remains: listener-driven layout changes can be overwritten by the later _layoutGenerated assignment, leaving stale layout data.

File summaries

File	Summary
src/core/CoreTextNode.ts	Updates constraint syntax and adds the textCalculated event.

Review details

Suppressed comments (2)

src/core/CoreTextNode.ts:343

• Node dimension payloads use the shared Dimensions shape with w/h (the v3 migration docs explicitly mark width/height as unavailable). This event therefore returns undefined to consumers reading payload.dimensions.w or .h, unlike the following loaded event. Emit the established keys here as well.

      dimensions: {
        width,
        height,
      },

src/core/CoreTextNode.ts:338

• Please add a regression test for both renderer paths that asserts textCalculated is emitted before loaded and carries the calculated dimensions. The existing CoreTextNode tests cover rendering and loaded behavior, but do not exercise this new event, so its ordering and payload can regress unnoticed.

    this.emit('textCalculated', {

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.