staticaddr/loopin: reject expiring deposits - #1202
Open
starius wants to merge 1 commit into
Open
Conversation
Manual static-address loop-ins can name explicit deposit outpoints. Those paths only checked that deposits were available. An old deposit could get a quote, then fail server init. Apply the same swappability and expiry runway check used by automatic selection to manual quotes and initiation. The client now rejects before contacting the server.
starius
marked this pull request as ready for review
August 17, 2026 23:32
hieblmi
self-requested a review
August 24, 2026 21:27
hieblmi
approved these changes
Aug 27, 2026
hieblmi
left a comment
hieblmi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix.
LGTM pending two improvements.
| "address parameters: %w", err) | ||
| } | ||
|
|
||
| info, err := s.lnd.Client.GetInfo(ctx) |
Collaborator
There was a problem hiding this comment.
we also need this call in the if branch above, so we might as well only call it once before the if, then reuse it here.
| ) | ||
| } | ||
|
|
||
| params, err := s.staticAddressManager. |
Collaborator
There was a problem hiding this comment.
we also need this call in the if branch above, so we might as well only call it once before the if, then reuse it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual static-address loop-ins can name explicit deposit outpoints. Those paths only checked that deposits were available. An old deposit could get a quote, then fail server init.
Apply the same swappability and expiry runway check used by automatic selection to manual quotes and initiation. The client now rejects before contacting the server.
Pull Request Checklist
docs/release-notes/release-notes-next.md, or apply theno-changeloglabel (required by CI)