staticaddr/address: harden multi-address startup - #1214
Draft
hieblmi wants to merge 3 commits into
Draft
Conversation
This was referenced Aug 27, 2026
hieblmi
force-pushed
the
multi-address-address-hardening
branch
from
August 27, 2026 10:28
56dcc74 to
7c226da
Compare
hieblmi
force-pushed
the
multi-address-core
branch
from
August 27, 2026 10:28
5600cbe to
ed02b6e
Compare
hieblmi
force-pushed
the
multi-address-address-hardening
branch
2 times, most recently
from
August 27, 2026 11:46
e85c0d3 to
6f82255
Compare
hieblmi
force-pushed
the
multi-address-core
branch
from
August 27, 2026 11:47
e392069 to
e5b0830
Compare
hieblmi
force-pushed
the
multi-address-address-hardening
branch
from
August 27, 2026 12:41
6f82255 to
c458192
Compare
hieblmi
force-pushed
the
multi-address-core
branch
from
August 27, 2026 12:41
e5b0830 to
a599226
Compare
Decode the requested address to its pkScript and use the active address index for ownership lookup. This avoids reconstructing and scanning every persisted static address.
Ignore an lnd duplicate-import error only when it names the expected Taproot output key. Propagate unrelated errors that happen to contain the words already exists.
hieblmi
force-pushed
the
multi-address-core
branch
from
August 28, 2026 10:34
a599226 to
bc63656
Compare
hieblmi
force-pushed
the
multi-address-address-hardening
branch
from
August 28, 2026 10:34
c458192 to
f709e0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 2 of 3 in the static-address multi-address stack. It depends on
#1139 and is based on
multi-address-coreso this PR only shows the addressstartup and issuance hardening.
This follow-up:
holding the general manager lock across wallet, server, and store calls;
loopd;wallet errors; and
Stack
Testing
go test ./staticaddr/... ./loopd ./cmd/loopgit diff --checkPull Request Checklist
docs/release-notes/release-notes-next.md.