-
Notifications
You must be signed in to change notification settings - Fork 10
docs: sync documentation with recent OpenAPI schema changes #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,6 +40,10 @@ The list endpoint returns all **active** sessions; expired sessions are not incl | |||||
|
|
||||||
| Session refresh creates a new session signing key from an existing active session. Use this when the customer is still present and the current session is close to expiration. If the session has already expired, reauthenticate with the original credential instead. | ||||||
|
|
||||||
| <Note> | ||||||
| The examples below show the legacy flow with `encryptedSessionSigningKey`. For new integrations, use the recommended [client-held-key flow](/snippets/global-accounts/client-keys#client-held-session-key) by sending a compressed `clientPublicKey` (66 hex characters), which avoids the decrypt step entirely. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a reader follows the new client-held-key recommendation, the link targets the snippet import path rather than the registered public page, causing navigation to a missing route instead of the session-key instructions.
Suggested change
Knowledge Base Used: Mintlify Documentation Site Prompt To Fix With AIThis is a comment left during a code review.
Path: mintlify/snippets/global-accounts/managing-sessions.mdx
Line: 44
Comment:
**Broken client-key documentation link**
When a reader follows the new client-held-key recommendation, the link targets the snippet import path rather than the registered public page, causing navigation to a missing route instead of the session-key instructions.
```suggestion
The examples below show the legacy flow with `encryptedSessionSigningKey`. For new integrations, use the recommended [client-held-key flow](/global-accounts/client-keys#client-held-session-key) by sending a compressed `clientPublicKey` (66 hex characters), which avoids the decrypt step entirely.
```
**Knowledge Base Used:** [Mintlify Documentation Site](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/mintlify-docs-site.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||||||
| </Note> | ||||||
|
|
||||||
| <Steps> | ||||||
| <Step title="First call — receive the challenge"> | ||||||
| ```bash | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -371,7 +371,7 @@ Show the payment details prominently in your UI: | |||||
| Set up webhook listeners to receive notifications when deposits are credited to the internal account. The account balance will update automatically. | ||||||
|
|
||||||
| <Info> | ||||||
| You'll receive `INTERNAL_ACCOUNT.BALANCE_UPDATED` webhook events when the internal account balance changes. | ||||||
| You'll receive `INTERNAL_ACCOUNT.BALANCE_UPDATED` webhook events when the internal account balance changes, and `INTERNAL_ACCOUNT.FUNDING_INSTRUCTIONS_UPDATED` when funding instructions are added or modified. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new webhook guidance does not tell readers to refresh cached
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: mintlify/snippets/internal-accounts.mdx
Line: 374
Comment:
**Missing cache invalidation guidance**
The new webhook guidance does not tell readers to refresh cached `fundingPaymentInstructions`; integrations following the same snippet's caching advice can continue displaying withdrawn or outdated deposit coordinates after receiving this event.
```suggestion
You'll receive `INTERNAL_ACCOUNT.BALANCE_UPDATED` webhook events when the internal account balance changes. When `INTERNAL_ACCOUNT.FUNDING_INSTRUCTIONS_UPDATED` reports new or withdrawn funding instructions, invalidate any cached `fundingPaymentInstructions` and fetch the account again.
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||||||
| </Info> | ||||||
| </Step> | ||||||
| </Steps> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new phrases “funds returned to sender” here and “funding instructions are added or modified” in
internal-accounts.mdxuse passive voice, contrary to the Mintlify writing standard, and obscure who performs these operational actions.Context Used: mintlify/AGENTS.md (source)
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!