Reject tail fetches for running WebSockets - #409
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #397.
Change
.tailfetch once its Request's WebSocket is running. The state check and queue drain sharejw.mu, so a fetch started after that transition cannot consume live outbound updates.TailHTMLcan apply initial updates.Verification
ConnectFnis paused. It checks that.tailreturns 404 and the WebSocket receives the update. The test returned 200 before the fix.JAWS_REQUIRE_NODE=1 go test -race ./...go vet ./...,go build ./...,staticcheck ./...,gosec -quiet ./...,gofumpt -l ., andgolangci-lint runviago run ...@v2.14.0.The bundled client loads the parser-blocking tail script before its deferred script opens the WebSocket on
DOMContentLoaded. A client that initiates both concurrently is out of scope. A failed pre-running tail write still cancels the Request because the one-shot drain has already removed its updates.