Harden forwarded client IP selection - #414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the rightmost address in the last
X-Forwarded-Forheader value, matching the address appended by one trusted proxy. Fall back to the rightmost address in the lastX-Real-IPvalue. If both valid addresses disagree, use the transport peer.This changes IP binding for multi-address
X-Forwarded-Forchains and conflicting IP headers. Proxies must set or remove both IP headers; controlling only one lets a client force transport-peer binding.Tests cover appended and duplicate headers, conflicting headers, and the pending-request cap with forged prefixes.
Fixes #401.
Validation
go generate ./...go test -race ./...go test ./...go vet ./...go build ./...staticcheck ./...golangci-lint rungosec -quiet ./...gofumpt -l serve.go jaws_test.go