fix(voice): flush zero-duration transcription segments - #2389
Open
kokoite wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 5c29f96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2383.
TranscriptionSynchronizerwaits for playback to start before forwarding paced text. When TTS completes with non-empty text but produces zero audio frames, no playback-started event can occur, so the segment keeps its transcript indefinitely.This change completes a segment only when both text and audio inputs have ended and its pushed audio duration is zero. It releases the existing text-forwarding task and rotates the completed segment. Segments containing audio continue to use the existing playback-gated pacing path.
Related duplicate report: #2384.
Changes Made
@livekit/agents.Pre-Review Checklist
Testing
pnpm test agents --silent— 141 files passed; 2,321 tests passed and 5 skipped.pnpm exec turbo run build --filter=@livekit/agents... --output-logs=errors-only— passed.pnpm exec turbo lint typecheck throws:check --output-logs=errors-only— 74 tasks passed.pnpm format:check— passed.silent replywith zero pending rotated segments.restaurant_agent.tsandrealtime_agent.ts: not applicable for this focused internal lifecycle fix.Additional Notes
pnpm api:checkreports existing declaration drift on current main. The same failure reproduces outside this branch, and its generated differences do not include the transcription synchronizer or any symbol changed here. This PR does not change public API.Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.