fix: use tmpfs for Docker execution - #200
Merged
Merged
Conversation
ekzyis
approved these changes
Aug 10, 2026
| case "$TARGET" in | ||
| lnd) | ||
| docker run --rm "${DOCKER_USER[@]}" \ | ||
| --tmpfs /tmp:rw,exec,size=1g \ |
Contributor
There was a problem hiding this comment.
just curious: could there be a reason to not want to use --tmpfs here?
Contributor
Author
There was a problem hiding this comment.
I only see reasons to have, but I could be wrong. On my tests it was able to run 2 times faster than without it.
NishantBansal2003
approved these changes
Aug 19, 2026
NishantBansal2003
left a comment
NishantBansal2003
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Verified by generating coverage reports across all four implementations, and this change does make it considerably faster than before
morehouse
approved these changes
Aug 28, 2026
Docker containers perform disk I/O by default, unlike the NYX VM, which runs from initramfs and is significantly faster. Use a tmpfs for /tmp in local execution, coverage reporting, and crash symbolization to better match the NYX environment. Also document the tmpfs option and add the ir scenario to the script usage information.
erickcestari
force-pushed
the
docker-run-tmpfs
branch
from
August 28, 2026 18:03
171064c to
a0cdfee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker containers perform disk I/O by default, unlike the NYX VM, which runs from initramfs and is significantly faster. Use a tmpfs for /tmp in local execution, coverage reporting, and crash symbolization to better match the NYX environment.
Also document the tmpfs option and add the ir scenario to the script usage information.