smite: compare channel types in minimal form - #218
Open
morehouse wants to merge 1 commit into
Open
Conversation
Previously we would compare channel types directly, which caused a false positive report when our open_channel.channel_type was non-minimal and the target responded with and accept_channel.channel_type in minimal form.
Contributor
|
FWIW, this should already be fixed in #209, where we define |
Collaborator
Author
|
Cool, yeah I'm behind on reviews and haven't looked at #209 yet. Will try to catch up soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would compare channel types directly, which caused a false positive report when our
open_channel.channel_typewas non-minimal and the target responded with anaccept_channel.channel_typein minimal form.Fixes #217.