ci: missing Slack webhook failure handling + fix notification format - #131
Open
carole-lavillonniere wants to merge 3 commits into
Open
ci: missing Slack webhook failure handling + fix notification format#131carole-lavillonniere wants to merge 3 commits into
carole-lavillonniere wants to merge 3 commits into
Conversation
The weekly release failed on Aug 28 and the alert never reached Slack. The
notify job failed with:
Missing input! Either a method or webhook is required to take action.
COSY_WEBHOOK_URL resolves to an empty string, so GitHub omits the `webhook`
input entirely and the action rejects the call. The secret exists but was
created 2026-08-12 and never updated -- one day before the weekly release
workflow landed in #108 -- and the notify path was not exercised until the
Aug 28 failure, so this alert has never worked.
Check the webhook in a preflight step that names the missing secret, and set
errors: true so Slack-side delivery failures fail the step instead of
reporting green.
Neither change can populate the secret; that still needs setting in repo
settings. They make the next failure say so in one line.
slack-github-action v4 ships js-yaml v5, which enforces stricter multiline
indentation. MESSAGE was a double-quoted YAML scalar, so its \n\n became real
newlines that were interpolated into the YAML payload at column 0 and broke
the document:
Invalid input! Failed to parse contents of the provided payload
SyntaxError: Expected property name or '}' in JSON at position 1
Single-quote MESSAGE so \n stays a two-character escape, and send the payload
as JSON, where an interpolated message cannot break the structure and \n is
exactly the newline Slack mrkdwn renders.
Verified end to end on a throwaway branch: the notify job was forced to run
under dryRun and delivered to Slack with errors: true, so a rejected delivery
would have failed the step.
carole-lavillonniere
changed the title
carole-lavillonniere
changed the title
carole-lavillonniere
changed the title
carole-lavillonniere
requested review from
a team and
dominikschubert
and removed request for
dominikschubert
August 31, 2026 12:18
carole-lavillonniere
marked this pull request as ready for review
August 31, 2026 12:18
carole-lavillonniere
requested review from
dfangl,
dominikschubert and
joe4dev
as code owners
August 31, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few things related to the slack notification that's sent in case of release failure: