feat(status): report detached plugins with a re-pin hint - #14
Merged
Merged
Conversation
A module whose HEAD is detached with no vimrc pin declared (e.g. a manual tag checkout during a maintenance session) used to render as 'Up-to-date' in status while update silently skips it - the user had no signal to act on. status now reports 'Detached' (warn glyph) with an offline hint: the nearest reachable tag (git describe --tags --abbrev=0, +1 subprocess for detached modules only) as the re-pin candidate, or the plain 'declare a pin or reattach a branch' fallback. Update messages untouched (pinned verbatim by tests/update.vader). tests/status.vader covers both hint variants (tag found / no tag).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A plugin whose HEAD is detached with no vimrc pin declared (e.g. a manual tag checkout during a maintenance session - like the fzf one diagnosed on 2026-09-16) rendered as "Up-to-date" in
:PluginManager statuswhileupdatesilently skips it. Status now reportsDetached(warn glyph) with an offline, actionable hint: the nearest reachable tag as the re-pin candidate, or "declare a pin or reattach a branch" when the module has no tags.Type of change
Related issue
n/a (follow-up of the detached-HEAD diagnosis on the maintainer's setup; no issue tracking it)
How was this tested?
Vim 9.1 (Debian). TDD: the two new status.vader cases (nearest-tag hint / tagless fallback) were written RED against main, then made GREEN by the status change. Update messages untouched (pinned verbatim by tests/update.vader).
git describe --tags --abbrev=0is offline and only runs for detached modules (+1 subprocess outside the perf.vader budget scope).make test-cipasses (216/216)make test-asyncpasses (16/16)make test-install-smokepasses (install/declare changes)(bug fixes: failing regression test before the fix)
Checklist
type(scope): subject)g:plugin_manager_*flag defaulting to off)v:version < 802untouched)