docs: Update gpui-kit dependency version to 0.7 in READMEs - #3304
Merged
Merged
Conversation
The README examples call `gpui_kit::open_window`, which was added in 0.7.0 (#3152), but the install snippets still asked for `gpui-kit = "0.6"`. Cargo resolves "0.6" to 0.6.x only, so copying the README fails with `cannot find function open_window in crate gpui_kit`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The README examples use
gpui_kit::open_window, which was added in 0.7.0 (#3152). The install snippets next to them still saygpui-kit = "0.6".For 0.x crates, Cargo treats
"0.6"as>=0.6.0, <0.7.0, so anyone who copies the README gets 0.6.6. The example then fails to compile:This PR changes every hardcoded
gpui-kitrequirement in Markdown from0.6to0.7:README.mdREADME.zh-CN.mdcrates/kit/README.md(the crates.io readme; the published page updates with the next release)crates/base/README.mdexamples/app_assets/README.mdskills/gpui-kit/references/usage.mdThe website docs are not affected because they use
{{gpui_kit_version}}.script/bump-version.shonly runscargo set-version, which does not touch Markdown. These snippets will need a manual update again on the next minor release.How to Test
git grep -nE 'gpui-kit = (\{ *version = )?"[0-9]' -- '*.md'lists only0.7.gpui-kit = "0.7"and the README example resolves to 0.7.0 and callsgpui_kit::open_window.Checklist
cargo runfor story tests related to the changes.🤖 Generated with Claude Code