[WRONG BRANCH] fix(usage): reseal sidecar OAuth attribution - #372
Conversation
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
sealRequestAttemptIdentity(logCtx.activeAttempt, logCtx.provider, rotatedAdapter.name, logCtx.accountLogLabel)in the sharedrotateSidecarProviderOn429path insrc/server/responses/core.tsso the attempt-levelaccountLogLabelmatches the request-level label.tests/oauth-account-attribution.test.tsthat exercises a web-search sidecar failover with two stored OAuth accounts and asserts both the top-level and attempt-level attribution are stamped to the account that actually served the successful retry.completedStream()to support the sidecar streaming retry regression and update the test harness accordingly.Testing
./node_modules/.bin/bun test tests/oauth-account-attribution.test.tsand the file passed (new sidecar attribution test included).bun run typecheckandbun run privacy:scanand both succeeded.bun run test; the modified test passed, but the repository-wide suite surfaced unrelated pre-existing timing/state failures in some Lab and endpoint tests (these failures are not caused by this change).Codex Task