[WRONG BRANCH] docs(skill): keep access-key creation out of agent sessions - #373
[WRONG BRANCH] docs(skill): keep access-key creation out of agent sessions#373luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
documentation
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6230c42908
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Secret-bearing commands | ||
|
|
||
| **Do not run `ocx access key create`.** Its one-time response contains the new plaintext |
There was a problem hiding this comment.
When an agent discovers the advertised ocx api-key create alias, this prohibition does not cover it, and src/cli/dispatch.ts forwards that alias to the same handleAccessCommand(["key", ...]) path that returns the plaintext credential. The new regression test likewise checks only the canonical spelling, so the stated secret boundary remains bypassable; prohibit all access-key creation paths from agent sessions and test both command spellings.
AGENTS.md reference: AGENTS.md:L287-L293
Useful? React with 👍 / 👎.
1 participant
Motivation
ocx access key create --json, which prints a one-time plaintext data-plane credential that can leak into model transcripts.Description
skills/ocx/SKILL.mdthat explicitly forbids runningocx access key createfrom an agent session and instructs the user to create keys in a separate terminal and only report the new key id.skills/ocx/references/03_recipes.mdto remove the agent-invokableocx access key createstep and to document a user-mediated rotation workflow that only removes the old key after the replacement is configured.tests/skill-ocx.test.tsthat asserts the skill contains the prohibition and that the recipes file does not include an executableocx access key createinvocation.Testing
node_modules/.bin/bun test tests/skill-ocx.test.ts, which passed (12 tests, 0 failures).bun run typecheckand the repositorybun run privacy:scan, both of which completed successfully.bun run testsuite was exercised but encountered unrelated environment/timing failures (lab sandbox / proxy-environment guards and a few timeouts); these failures are external to the documentation-only changes and do not affect the focused regression added here.Codex Task