Skip to content

[WRONG BRANCH] fix(cli): correct logs follow capability contract - #375

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-inaccurate-jsonl-output-for-follow
Draft

[WRONG BRANCH] fix(cli): correct logs follow capability contract#375
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-inaccurate-jsonl-output-for-follow

Conversation

@luvs01

@luvs01 luvs01 commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The ocx capabilities entry for ocx logs --follow claimed that --follow streams JSONL and implied --jsonl, but the logs implementation only emits JSON when --jsonl is explicitly provided, causing automation that trusts the capability metadata to mis-parse followed output.

Description

  • Update the capability metadata in src/cli/capabilities.ts to state that --follow polls for new rows and that --jsonl must be supplied to emit JSONL.
  • Regenerate the checked-in CLI management-surface reference skills/ocx/references/01_management_surface.md so the docs/skill surface matches the corrected contract.
  • Add a focused regression test in tests/cli-capabilities.test.ts that asserts the --follow flag summary no longer claims to imply JSONL output.

Testing

  • Ran the focused capability unit test with node_modules/.bin/bun test tests/cli-capabilities.test.ts and it passed.
  • Verified the generated management-surface with node_modules/.bin/bun run skill:surface:check and it reported the reference is current.
  • Ran typechecking with node_modules/.bin/bun run typecheck and node_modules/.bin/bun run privacy:scan, and both checks passed.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T05:42:23.188016Z c08240f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 145c568d-b576-48ca-bb3c-0f32291da4a6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(cli): correct logs follow capability contract [WRONG BRANCH] fix(cli): correct logs follow capability contract Aug 30, 2026
@github-actions
github-actions Bot marked this pull request as draft August 30, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant