Skip to content

[WRONG BRANCH] test(cli): make logout non-mutation sentinel adversarial #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Draft

[WRONG BRANCH] test(cli): make logout non-mutation sentinel adversarial #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/cli-dispatch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,11 @@ describe("logout parses argv before touching the credential store", () => {
* probing the sandbox rather than by reading the test -- the file genuinely does not exist at
* `<tmp>/.opencodex/auth.json` when the suite starts.
*
* With a credential present the file exists, so "byte-identical before and after" is a claim
* with content: any write, including the destructive `--json`-as-provider-name path, changes it.
* Seed the provider that malformed parsing could remove so a destructive store mutation must
* change the bytes; rewriting an unrelated credential unchanged would not prove that.
*/
const seed = async (): Promise<string> => {
await saveCredential("claude", { access: "seed-access", refresh: "seed-refresh", expires: Date.now() + 600_000 });
const seed = async (provider = "claude"): Promise<string> => {
await saveCredential(provider, { access: "seed-access", refresh: "seed-refresh", expires: Date.now() + 600_000 });
const contents = snapshot();
expect(contents, "seeded auth.json must exist or the non-mutation assertions are vacuous").not.toBeNull();
return contents!;
Expand Down Expand Up @@ -180,7 +180,7 @@ describe("logout parses argv before touching the credential store", () => {
};

test("a flag is never read as a provider name and leaves the store byte-identical", async () => {
await seed();
await seed("--json");
const result = await runLogout(["--json"]);
expect(result.code).toBe(2);
expect(result.before).not.toBeNull();
Expand Down
Loading