[WRONG BRANCH] fix(cli): mark access-key usage as unavailable when attribution is absent - #378
[WRONG BRANCH] fix(cli): mark access-key usage as unavailable when attribution is absent#378luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
ocx access key listfrom misleading operators by printing numeric zeros and "never" when the server has not provided dataset-level attribution (attributionSince).Description
formatKeyRowsinsrc/cli/access.tsto inspectpayload.attributionSinceand treat usage as unavailable when that field is absent, printingunavailablein the request-count column and suppressing numeric/"never" output in that case.ambiguousdiscriminant and for genuine numeric/never-used cases whenattributionSinceis present.tests/cli-dto-fidelity.test.tsthat suppliesattributionSincefor the numeric cases and adds a new test asserting the CLI printsunavailable(and not0ornever) when attribution is missing.Testing
./node_modules/.bin/bun test tests/cli-dto-fidelity.test.ts, which passed (all tests in that file green).bun run typecheckandbun run privacy:scan, both of which succeeded../node_modules/.bin/bun run test; the full repository test run exercised many unrelated areas and surfaced pre-existing failures in lab and integration tests that are outside the scope of this focused formatting fix.Codex Task