Skip to content

[WRONG BRANCH] fix(cli): mark access-key usage as unavailable when attribution is absent - #378

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-incorrect-key-usage-labeling
Draft

[WRONG BRANCH] fix(cli): mark access-key usage as unavailable when attribution is absent#378
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-incorrect-key-usage-labeling

Conversation

@luvs01

@luvs01 luvs01 commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent the human-readable ocx access key list from misleading operators by printing numeric zeros and "never" when the server has not provided dataset-level attribution (attributionSince).
  • Align CLI behavior with the GUI, which already treats a missing attribution boundary as unavailable rather than claiming zero usage.

Description

  • Change formatKeyRows in src/cli/access.ts to inspect payload.attributionSince and treat usage as unavailable when that field is absent, printing unavailable in the request-count column and suppressing numeric/"never" output in that case.
  • Preserve the existing rendering for the ambiguous discriminant and for genuine numeric/never-used cases when attributionSince is present.
  • Add a focused regression test in tests/cli-dto-fidelity.test.ts that supplies attributionSince for the numeric cases and adds a new test asserting the CLI prints unavailable (and not 0 or never) when attribution is missing.

Testing

  • Ran the focused suite ./node_modules/.bin/bun test tests/cli-dto-fidelity.test.ts, which passed (all tests in that file green).
  • Ran bun run typecheck and bun run privacy:scan, both of which succeeded.
  • Attempted a full ./node_modules/.bin/bun run test; the full repository test run exercised many unrelated areas and surfaced pre-existing failures in lab and integration tests that are outside the scope of this focused formatting fix.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T05:50:17.813295Z 0eb64cc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ef50a845-3c73-4bbb-a646-53125552da58


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix(cli): mark access-key usage as unavailable when attribution is absent [WRONG BRANCH] fix(cli): mark access-key usage as unavailable when attribution is absent Aug 30, 2026
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 30, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant