Skip to content

[WRONG BRANCH] tests: use private temp dir for route scanner probe to prevent symlink clobbering #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WRONG BRANCH] tests: use private temp dir for route scanner probe to prevent symlink clobbering #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/management-route-registry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { describe, expect, test } from "bun:test";
import { existsSync, readFileSync, readdirSync } from "node:fs";
import { existsSync, mkdtempSync, readFileSync, readdirSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { dirname, join, resolve } from "node:path";
import { fileURLToPath } from "node:url";
import { MANAGEMENT_ROUTES } from "../src/server/management/route-registry";
Expand Down Expand Up @@ -122,7 +123,8 @@ describe("management route registry reconciliation", () => {
// Drives the fail-loud path red on purpose: without this, a scanner that silently
// defaulted to GET would satisfy every other test in this file while producing a
// route table nobody could trust.
const tmp = join(repoRoot, ".tmp-scanner-probe.ts");
const tempDir = mkdtempSync(join(tmpdir(), "ocx-route-scanner-"));
const tmp = join(tempDir, "scanner-probe.ts");
const source = [
"export async function handleProbe(ctx: any): Promise<Response | null> {",
" const { url, req } = ctx;",
Expand All @@ -133,13 +135,13 @@ describe("management route registry reconciliation", () => {
" return null;",
"}",
].join("\n");
require("node:fs").writeFileSync(tmp, source);
writeFileSync(tmp, source);
try {
const { unresolved } = distinctRoutes(scanRoutes(tmp));
expect(unresolved.map(r => r.path)).toEqual(["/api/probe/unknowable"]);
expect(unresolved[0]?.method).toBeNull();
} finally {
require("node:fs").rmSync(tmp, { force: true });
rmSync(tempDir, { recursive: true, force: true });
}
});

Expand Down
Loading