Conversation
e84b999 to
1d9e083
Compare
|
This is good in principle. I've rebased it to test it and it seems to work. One thing I noticed is that there are thick borders between the window titles. This border style is usually used for resizing which doesn't apply here. Maybe this should use the separator style. |
| GetSeatMonoStyle { | ||
| seat: Seat, | ||
| }, | ||
| SetSeatMonoStyle { | ||
| seat: Seat, | ||
| style: MonoStyle, | ||
| }, | ||
| GetWindowMonoStyle { | ||
| window: Window, | ||
| }, | ||
| SetWindowMonoStyle { | ||
| window: Window, | ||
| style: MonoStyle, | ||
| }, |
There was a problem hiding this comment.
All of these need a ContainerTarget parameter which was just added.
|
I've updated with a separate commit (I would have folded the changes in the stack but I don't use git often and it seems quite annoying to do). I've written the changes on a very slow laptop while on the road, so I didn't have a change to properly test them, hopefully it's still fine.
Feel free to change this yourself since you will be able test the changes way more easily than I could at least for a couple of weeks. I remember the border being there but didn't know about the resizing feature, so I assumed it was a different style that didn't bother me. |
This is a pure refactor, there is no behavior change. The next series of patches will introduce the `stacked` mono style.
Inspired by i3/sway stacking, the title bars are below each other instead of next to each other. Focus and scrolling works as expected with the axis change. Nothing uses this yet, later changes will wire it to the config.
This introduces `MonoStyle` with the appropriate toggles so changes can be done via a shortcut and initial value can be set, as with the other layout tools.
Similar to the existing actions allowing the user to control the behavior.
This sets the mono style of newly created containers, does not affect existing containers. This is set to `"tabbed"` to preserve backwards compatibility.
We've just introduced this setting, so we need to expose it.
This also fixes the `"window-rule"` action list which contained `"toggle-split"` twice instead of `"toggle-mono"`.
This feature was added to allow users to choose which target actions apply to, it's only natural we do the same here.
dab18e3 to
5ba71a8
Compare
|
I've rebased your changes. A few more things that I've noticed:
|
2 participants
Discoverability of the codebase and test writing was largely aided by AI to (majorly) speed up the process, but everything was reviewed/(re)written by me and I can vouch for the changes. Whether they're good enough is still up in the air, this is my first contribution. :)
This does the part which is interesting to me in #1077, I don't think I fully understand the OP's intent.