fix: use Greek Γ, not Cyrillic Г, in k-point paths - #359
Conversation
The band-structure notebooks spelled the zone centre with Cyrillic Ghe (U+0413) instead of Greek capital gamma (U+0393). The server matches the label against the reciprocal lattice by string, so any k-path containing it fails at pw_bands with "Point Г not found in reciprocal lattice". In defect_point_substitution_graphene_simulation.ipynb this is live code and affects both RUN_PROFILE branches, so the notebook cannot complete as merged. In the four workflow notebooks it sits in the commented KPATH example, which is where the graphene notebook copied it from - fixing those too stops it propagating into the next notebook written from them. Only the character changes; the diff is byte-identical otherwise. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe notebooks replace Cyrillic ChangesGamma label correction
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change replaces the incorrect Cyrillic character with Greek Gamma in affected notebook k-point paths, restoring the broken graphene workflow without changing intended behavior elsewhere. No actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Five notebooks spelled the Brillouin-zone centre with Cyrillic Ghe (U+0413) instead of Greek capital gamma (U+0393). The two characters are visually identical in most fonts.
The server resolves the k-point label against the reciprocal lattice by string comparison, so any path containing it fails at the
pw_bandsstep with:Impact
specific_examples/defect_point_substitution_graphene_simulation.ipynbworkflows/band_structure.ipynbworkflows/band_structure_hse.ipynbworkflows/band_structure_magn.ipynbworkflows/valence_band_offset.ipynbThe graphene notebook is the one that actually breaks: both
RUN_PROFILEbranches (debugandproduction) carry the bad character, so it cannot complete as merged.The other four hold it in the commented
KPATHexample — which is where the graphene notebook copied it from. Fixing those too is the point of the PR: it stops the character propagating into the next notebook written from them. It has already propagated at least twice.Verification
U+0400–U+04FF) across all.ipynb,.py,.mdand.jsonnow returns zero matches.🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Γ) in k-path labels.Bug Fixes