Sync alert and report screenshots with the restyled selects [ignore_release] - #62
Merged
Merged
Conversation
AltamashShaikh
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Core #25033 restyled the expandable select dropdowns and added a standard drag handle component, which changed how the Custom Alerts form renders. This plugin keeps its own copies of the
CustomAlerts_*captures undertests/UI/expected-ui-screenshots/, so its6.x-devbuild has been red since 17 August with five failing captures — four alert-form ones differing by 4698 px and the report error by 1233 px.CustomAlerts synced its own copies in matomo-org/plugin-CustomAlerts#274 and is green again; MicrosoftTeams had the identical problem and was fixed the same way in matomo-org/plugin-MicrosoftTeams#47. This is the last of the three.
The five captures are regenerated from run
32073288852, the failing run on6.x-devat the same commit this branch is based on. No source changes — the rendering is correct, only the baselines were stale. Each was reviewed to confirm it shows a complete, intended render: the error captures still carry their "Slack Channel ID cannot be empty" notification, and the restyled bordered select is visible on the alert condition field.The same change will break these captures on
5.x-devwhen the 5.x backport of #25033 lands.Issue No
Follow-up to matomo-org/matomo#25033. No separate issue.
Steps to Replicate the Issue
6.x-dev.should show load a new alert add screen,should show slack channel ID input as disabled as Oauth token not configured,should show slack channel ID input as enabled when Oauth token configuredand bothshould show show error if channelID not setcases fail, differing by 4698 px on the alert-form captures and 1233 px on the report one.Checklist