Skip to content

Sync the expected UI screenshots for the core select restyle [ignore_release] - #65

Merged
AltamashShaikh merged 3 commits into
6.x-devfrom
sync-select-restyle-screenshots
Sep 1, 2026
Merged

Sync the expected UI screenshots for the core select restyle [ignore_release]#65
AltamashShaikh merged 3 commits into
6.x-devfrom
sync-select-restyle-screenshots

Conversation

@snake14

@snake14 snake14 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

Core #25100 restyled the standard select to match the design system, changing how every uicontrol="select" field renders. 12 expected UI screenshots in this plugin contain such a field, so the 6.x-dev UI build has been red since that merge. This updates those expectations to match. Five of them are this plugin's own copies of the CustomAlerts_* captures, which live here as well as in CustomAlerts.

No plugin code changes, so there is no user-visible change and no release: the commit and this title carry [ignore_release].

Issue No

Related to matomo-org/matomo#25100.

Steps to Replicate the Issue

  1. Run the plugin's UI tests against core 6.x-dev at or after 34d16e91d7.
  2. Expected: the suite passes.
  3. Actual: 12 screenshot comparisons fail, with every difference confined to select controls and the reflow their changed height causes.

Checklist

  • [✖] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

…release]

Core #25100 restyled the standard select, so every capture containing one now
differs. These are CI's own images from the 6.x-dev run 33235250610.
Core #25100 gave the standard select a :focus-within border, so a capture taken
straight after picking an option races the focus ring and lands on either state.
The blur in the previous commit was a no-op: two runs either side of it were
byte-identical, so the border is core's :hover half of `&:hover, &:focus-within`,
left painted because the click that picks an option leaves the pointer on the control.
@snake14
snake14 marked this pull request as ready for review September 1, 2026 00:53
@snake14
snake14 requested a review from a team September 1, 2026 00:53
@AltamashShaikh
AltamashShaikh merged commit cdd7bf3 into 6.x-dev Sep 1, 2026
13 checks passed
@AltamashShaikh
AltamashShaikh deleted the sync-select-restyle-screenshots branch September 1, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants