fix(deps): pick up genoray 4.0.1 and drop tracing from the build - #348
Merged
Conversation
Moves the Python pin to genoray 4.0.1 and the svar2-codec / genoray_core git rev from 1bac5f9 (tag 4.0.0) to d66ec0e (tag 4.0.1). 4.0.1 gates `tracing` and `tracing-subscriber` behind genoray's `conversion` feature (d-laub/genoray#165). GVL links `genoray_core` with `default-features = false` -- the query-only core -- and never emits or observes a tracing event, but until 4.0.1 those crates were unconditional dependencies and were compiled into every GVL build anyway. Cargo.lock drops from 237 to 226 crates: lazy_static, matchers, nu-ansi-term, sharded-slab, thread_local, valuable, and the five tracing* crates. No GVL source change is needed; the genoray_core and svar2_codec APIs GVL uses are unchanged. Also records the pin invariant in Cargo.toml: this rev must stay in step with the `genoray` Python pin, because the Rust code here reads svar2 stores that the Python package writes, so a format change landing in only one of the two is invisible until it corrupts a read. Verified: 1130 passed / 58 skipped / 4 xfailed pytest, 6 passed slow tier, 134 + 4 cargo tests, ruff check + format clean, pyrefly 0 errors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #347. Moves the Python pin to genoray 4.0.1 and the
svar2-codec/genoray_coregit rev from1bac5f9(tag 4.0.0) tod66ec0e(tag 4.0.1).Why
4.0.1 gates
tracingandtracing-subscriberbehind genoray'sconversionfeature (d-laub/genoray#165). GVL linksgenoray_corewithdefault-features = false— the query-only core — and never emits or observes a tracing event, but until 4.0.1 those were unconditional dependencies and got compiled into every GVL build anyway.#347 made this visible: aligning the Rust pin to 4.0.0 added 11 transitive crates GVL doesn't use. This removes them.
Cargo.lock: 237 → 226 crates. Gone:lazy_static,matchers,nu-ansi-term,sharded-slab,thread_local,valuable, and the fivetracing*crates.No GVL source change was needed — the
genoray_coreandsvar2_codecAPIs GVL uses are unchanged.Also
Records the pin invariant in
Cargo.toml: this rev must stay in step with thegenorayPython pin, because the Rust code here reads svar2 stores that the Python package writes. A format change landing in only one of the two is invisible until it corrupts a read — which is the failure mode that let the rev sit at genoray 3.0.0 while the Python package moved to 3.4.0.Verification
pytest tests -q(full tree)pytest tests -q -m slowcargo-testruff check/ruff format --checktypecheck(pyrefly)cz bump --dry-run0.42.0 → 0.42.1, PATCHTyped
fix(deps):deliberately: #347'sbuild(deps):commits gave[NO_COMMITS_TO_BUMP], so genoray 4.x support merged without cutting a release. This PR ships both.🤖 Generated with Claude Code