Add verified binary release workflow - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new installer’s input validation has a concrete defect (repository format check) and a tag-validation mismatch with the release workflow that can cause valid releases to fail installation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a tag-driven, GoReleaser-based binary release pipeline with an accompanying verified installer, updates documentation to recommend that install path, and bumps the project version to 0.2.1.
Changes:
- Introduce a hardened GitHub Actions release workflow plus GoReleaser configuration for multi-OS/arch archives and checksums.
- Add
install-release.shand offline Bats integration tests for installer success/failure paths. - Update docs, CI, Make targets, and version strings to reflect the new release/install flow and 0.2.1.
File summaries
| File | Description |
|---|---|
| test/install-release.bats | Adds offline Bats tests for the release installer (success + multiple failure modes). |
| termcourse.go | Bumps development fallback version to 0.2.1. |
| termcourse_test.go | Updates version expectations for build override and dev version formatting. |
| README.md | Documents the recommended prebuilt release installer and release operations. |
| meta-topic.md | Updates installation instructions to prefer the release installer and mentions pinned installs. |
| Makefile | Adds check, integration tests, install/clean targets, and tightens build flags. |
| internal/ui/ui_test.go | Updates UI test expectations to the 0.2.1 version string. |
| install-release.sh | Adds a verified release installer for Linux/macOS with checksum + version verification. |
| .goreleaser.yaml | Adds GoReleaser v2 config for cross-platform archives and checksums. |
| .github/workflows/release.yml | Adds tag-driven + dispatchable release workflow with validation and publish steps. |
| .github/workflows/ci.yml | Aligns CI with make check, adds GoReleaser config validation, and installs Bats. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
make checkshellcheck install-release.shRelease note
The existing
v0.2.0tag remains immutable. Tagv0.2.1only after this PR reachesmaster; that tag will exercise the new workflow and create the first binary release assets.