FIX: Harden cross-platform release validation - #18
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The workflow changes are small, consistent with the stated goals, and primarily add additional validation/build safety checks without altering release publishing semantics.
Pull request overview
This PR hardens the release pipeline by ensuring each OS job validates it is building/testing the exact immutable commit that was validated from the release tag, and by adding an explicit native go build step across the OS test matrix before publishing.
Changes:
- Add a post-checkout commit verification step in the OS matrix
testjob to ensure the checked-out commit matches the validated tag’s resolved commit SHA. - Add an explicit
go build -buildvcs=false -trimpath ./cmd/termcoursestep to the OS matrixtestjob. - Keep the existing Windows installer fixture test intact while running after the added build step.
File summaries
| File | Description |
|---|---|
| .github/workflows/release.yml | Adds per-matrix-job commit immutability verification and an explicit native build step before release publication. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go vet ./...go test -race ./...go build -buildvcs=false -trimpath ./cmd/termcoursebats test(10 tests)