-
Notifications
You must be signed in to change notification settings - Fork 87
Performance package withdrawal limits #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
metapileks
wants to merge
15
commits into
develop
Choose a base branch
from
pileks/met-708-price-based-performance-package-vesting-and-distribution
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ca9818a
performance package withdraw limits scaffolding
metapileks 17b8b20
pbpp withdrawal policy - migration
metapileks 4a45b65
pbpp - gate actions before resize
metapileks cf94ebe
pbpp - token withdrawal mechanics - basic
metapileks 1c73577
new pbpp burn package logic
metapileks c029b92
pbpp - init with limits
metapileks 9e261ba
pbpp token withdrawal mechanism
metapileks 6675ff6
pbpp - helpers for token withdrawal logic
metapileks 221b4a2
pbpp - withdraw via sell mechanics
metapileks e756c88
propose and execute pbpp changes
metapileks 3d5b0d9
pbpp - example token withdrawal with withdrawal limits on
metapileks c34243c
add scripts for migration and admin proposal of new package terms
metapileks 2430998
optionally sweep quote account + stray quote tokens on performance pa…
metapileks 83fc23a
burn pp - move quote sweep into a single argument client-side
metapileks 64e1020
fix(pbpp): reject oracle whose base mint is not the package's mint
metapileks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will admin always be an EOA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for this question?
The admin already isn't an EOA (it's a squads multisig) and this works just fine with it being a squads multisig. The vault can be a payer, it just has to have an adequate SOL balance, and there is no reentrancy.
LMK if something particular is bothering you here.