feat(database): back up SQLite before startup migrations - #186
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex Please review current head Focus on SQLite snapshot integrity, WAL correctness, migration/retention ordering, PostgreSQL non-regression, recovery documentation, and tests that could pass for the wrong reason. For each finding, return |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8ee805b43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex Please re-review current head |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Review follow-up disposition on current head
|
|
@codex review Please run the second unchanged-head review of |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Review loop complete on unchanged head Two consecutive complete rounds found no product-code defect. Each round received current-head verdicts from GitHub Codex, Codex CLI, Claude Code, and the repository-rules reviewer. The original inline retention thread is fixed, replied to, re-reviewed, resolved, and no review thread remains open. Driver verification on this head: Non-blocking follow-ups are filed as #187 and #188. Generated graph artifacts remain intentionally deferred to a graph-only closeout PR, so #39 stays open after this feature PR. The review stop rule is now satisfied; merge remains an explicit owner decision. |
Summary
PRAGMA quick_check, then publish atomicallyRefs #39
Deliberate exclusions
graphify-out/artifactsThe committed graph was validated against this feature head with
uvx --from graphifyy graphify update .: the new coordinator, backup, and verifier types were present andGRAPH_REPORT.mdnamed inputc8ee805b. Per the project rule that generated graph artifacts stay out of feature PRs, those changes were reverted. After this feature merges, a separate graph-only PR from updatedmainwill refresh the committed graph and useCloses #39.Verification — driver-verified on
16d6dd8bd2dde14b8b694b3c97cdc96ab498b43c./scripts/ci-local.sh allCollectify.Tests: 783 passed (baseline 761; +22)Collectify.PostgresTests: 15 passed (baseline 14; +1)Kyoder implemented the initial three increments. Codex CLI
gpt-5.6-terraapplied the review-fix commit16d6dd8; Kyoder independently reran its M11/M12 mutations and the full local CI equivalent on the resulting head.Test plan
Recovery contract
A restore stops the container, copies the selected snapshot over
collectify.db, removes stale WAL/SHM files, and starts the previous known-good image by immutable digest from that release'simage.json. Mutable tags such aslatestare explicitly excluded.