Skip to content

tinysoap-browser-min.js fails when loading with RequireJS.org#10

Description

@hhkaos

Hi there!,

First of all, thank you for the amazing work you have done! 馃挭 .

I'm just opening this issue because I have been playing around with this library and I have noticed there is a problem at the begging of the script. When it checks if typeof require === undefined while the requirejs library is loaded it fails because it tries to load NodeJS core modules.

Would it make sense to replace that condition for something like this: if (typeof window === 'undefined')? If you think it does I'll be have to send a PR.

You can see more at this thread

Best regards,
Raul

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions