Lock file maintenance - #153
Merged
Merged
Conversation
Deploying microbit-connection with
|
| Latest commit: |
5e1e11b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://545f0444.microbit-connection.pages.dev |
| Branch Preview URL: | https://renovate-lock-file-maintenan.microbit-connection.pages.dev |
The lock file refresh moves typescript 5.8.3 -> 5.9.3, whose DOM lib narrows BufferSource from `ArrayBufferView | ArrayBuffer` to `ArrayBufferView<ArrayBuffer> | ArrayBuffer`. A bare Uint8Array is backed by ArrayBufferLike, so it may be a SharedArrayBuffer view and crypto.subtle no longer accepts it. That broke tsc and typedoc alike. nrf-intel-hex is the only loose edge here: slicePad is typed as a bare Uint8Array but always allocates a plain ArrayBuffer. Assert once where that value enters, in createAppBin, and carry Uint8Array<ArrayBuffer> through the chain down to the digest call, so the requirement is stated where it applies rather than papered over at the point of failure. createLegacyInitPacketV1 keeps the wide parameter: it ignores the data entirely, so it has no such requirement and still satisfies the call site by contravariance. None of these are exported from the package entry points, so the public type surface is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: (in timezone Europe/London)
* * 1-7 * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate CLI.