Publish to npm via trusted publishing - #157
Merged
Merged
Conversation
Replaces the NPM_TOKEN secret with OIDC, following makecode-embed. The build job packs the workspace tarball and a separate publish job, with no checkout and the only id-token permission, stages it to npm from the npm-publish environment. npm stage is unaware of workspaces, but publishing the tarball from npm pack -w sidesteps that. npm pack now runs on every build so packaging problems fail a branch build rather than a release. Also drops the packages: write permission and the GITHUB_TOKEN passed to npm ci, left over from GitHub Packages; nothing here resolves from that registry.
Deploying microbit-connection with
|
| Latest commit: |
8df2b03
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1501437b.microbit-connection.pages.dev |
| Branch Preview URL: | https://npm-trusted-publishing.microbit-connection.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the NPM_TOKEN secret with OIDC, following makecode-embed. The build job packs the workspace tarball and a separate publish job, with no checkout and the only id-token permission, stages it to npm from the npm-publish environment. npm stage is unaware of workspaces, but publishing the tarball from npm pack -w sidesteps that. npm pack now runs on every build so packaging problems fail a branch build rather than a release.
Also drops the packages: write permission and the GITHUB_TOKEN passed to npm ci, left over from GitHub Packages; nothing here resolves from that registry.