Skip to content

[Extensibility Request] issue 29640: use document type enum in blocked customer event - #10520

Draft
Marko Aleksandric (AleksandricMarko) wants to merge 2 commits into
mainfrom
ai-ext-fix/ext_issue-29640
Draft

[Extensibility Request] issue 29640: use document type enum in blocked customer event#10520
Marko Aleksandric (AleksandricMarko) wants to merge 2 commits into
mainfrom
ai-ext-fix/ext_issue-29640

Conversation

@AleksandricMarko

@AleksandricMarko Marko Aleksandric (AleksandricMarko) commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Extensions need the blocked-customer check to preserve extensible general journal document type values instead of reducing them to an option integer. This PR changes the event contract to use the Gen. Journal Document Type enum and publishes the enum value directly.

Source issue repository: microsoft/AlAppExtensions; issue number: 29640

Changes Made

  • Customer.OnBeforeCheckBlockedCust - changed DocType from an option to the extensible Gen. Journal Document Type enum and removed the integer conversion across W1 and all existing layer counterparts.

Fixes AB#620150

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added Finance GitHub request for Finance area and removed SCM GitHub request for SCM area labels Aug 21, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 21, 2026
@AleksandricMarko

Copy link
Copy Markdown
Contributor Author

Copilot

it is not allowed to replace type of parameter in OnBeforeCheckBlockedCust
instead, you need to create new event with updated parameters, to obsolete existing event and also all calls of existing event to surround with if not CLEAN

Co-authored-by: AleksandricMarko <133204513+AleksandricMarko@users.noreply.github.com>

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Copilot

it is not allowed to replace type of parameter in OnBeforeCheckBlockedCust
...

Implemented in commit a18ef8bb.

  • Restored OnBeforeCheckBlockedCust with original Option DocType under #if not CLEAN29.
  • Marked the legacy event obsolete.
  • Added new enum-based event OnBeforeCheckBlockedCust2.
  • Updated publishers to call the legacy event only in non-CLEAN builds and then the new event when not already handled.
  • Propagated the same change across all affected layer files.

@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event-request Finance GitHub request for Finance area needs-approval Workflow runs require maintainer approval to start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants