[Main] - Batch printing Posted Sales Shipments with "Show Serial/Lot Number Appendix" mixes lot information between documents

[DeepsShukla]

Workitem Bug 647293: [Repair Item] [All-E] [GB] Batch printing Posted Sales Shipments with "Show Serial/Lot Number Appendix" mixes lot information between documents

Fixes AB#647293

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Accept with Suggestions

What this PR does

The GB Posted Sales Shipment report (SalesShipment.rdlc) prints a Serial/Lot Number appendix. When several shipments are printed in one batch, lot information appears mixed between documents. This PR removes the <PageBreak><BreakLocation>Start</BreakLocation></PageBreak> from the appendix tablix.

The change is layout-only and does not touch the shipment data or posting. The reported symptom, however, is lot data appearing to belong to the wrong document, which usually comes from how the appendix region is scoped or grouped per document, not only from where a page break falls. Removing the forced page break may fix how the appendix pages line up with each document, but it is not obvious from the diff that it addresses the grouping of lot data itself (see S1).

Suggestions

S1 - Confirm the page-break change actually fixes cross-document mixing
The appendix tablix is a separate region filtered on TrackingSpecBufferItemNo. Removing the start page break changes pagination, not how lot rows are grouped per document. Please verify with a batch of at least two shipments (both with serial/lot appendix) that each document now shows only its own lots, and confirm the appendix is scoped to the correct document group. If the mixing came from grouping/scope, a page-break change alone may not fully fix it.

Risk assessment and necessity

Risk: Low. This is a report-layout change in the GB layer only; it cannot corrupt data and does not affect posting. The main risk is that it changes pagination without fully resolving the root cause, so the appendix could still mix lots in some batch cases. A regression test is not practical for RDLC rendering, so absence of a test is acceptable here - manual verification with a multi-document batch is the right check.

Necessity: The scenario is valid and customer-facing (GB serial/lot appendix on posted shipments). A fix is warranted; the open question is whether this specific change is sufficient (S1).

---

[AI-PR-REVIEW] version=1 promptVersion=2 system=github pr=10529 round=1 by=alexei-dobriansky at=2026-08-23T00:12:40Z lastSha=d1eacd26694d17395a5e1630de316ee9b58f028f reviewKey=96d6cca42fc69e9666dbc440f2bb92301b3b28809f84e53d19baacd61e2aec93 suggestions=S1@422e2eec