Support reproducible text-only MobiusBuilder exports - #2634
Support reproducible text-only MobiusBuilder exports#2634Ti-Tai Wang (titaiwangms) wants to merge 4 commits into
Conversation
Ensure direct Mobius exports use the requested model snapshot so unquantized baselines remain comparable with quantized workflows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e10674c1-6909-4b09-9f5a-d41b28c89d2d
There was a problem hiding this comment.
Pull request overview
This pull request updates Olive’s MobiusBuilder ONNX pass to forward the Hugging Face model revision (from HfModelHandler load kwargs) into mobius.build, ensuring exports stay pinned to the intended Hugging Face snapshot and aligning behavior with workflows that materialize a local pinned checkpoint upstream.
Changes:
- Forward
revisionfromHfModelHandler.get_load_kwargs()intomobius.build(...). - Add a unit test asserting that the
revisionkwarg is passed through tomobius.build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
olive/passes/onnx/mobius_model_builder.py |
Extracts revision from HF load kwargs and passes it into mobius.build to pin exports to the requested snapshot. |
test/passes/onnx/test_mobius_model_builder.py |
Adds a unit test that verifies the revision kwarg is forwarded to mobius.build. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Expose Mobius text-only architecture selection and keep generated runtime assets on the same immutable Hugging Face revision. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 72aa2acc-7ef6-4fe4-b760-921d80d29dd7
|
do we still need this? |
|
Yes, this is still needed for two reasons:
The revision forwarding is also still needed: The distinction may be clearer if the Olive-facing setting is named |
Replace misleading k_quant heuristic names with descriptive high_precision names while preserving deprecated aliases for existing configurations and callers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d9a8b1f-9b83-4a52-bfe4-92437196e1c1
|
LGTM. Would leave to Jambay Kinley (@jambayk) Xiaoyu (@xiaoyu-work) for an approval |
Describe your changes
Extend
MobiusBuilderso direct exports can reproducibly select the text backbone of supported multimodal checkpoints:HfModelHandlerrevision tomobius.build;text_onlypass setting, defaulting tofalse;text_only=Trueto Mobius only when explicitly requested, preserving compatibility for existing recipes;trust_remote_codepolicy to ORT GenAI config/tokenizer asset generation.text_onlyselects the model architecture during Mobius build. It is intentionally distinct fromcomponents_to_export, which filters components after a package has already been built and therefore cannot produce a complete standalone runtime package by itself.This enables VLM-capable checkpoints such as
Qwen/Qwen3.6-35B-A3Bto produce a single standalone text decoder with root-levelmodel.onnxand decoder-only GenAI configuration while keeping weights and tokenizer assets on one immutable Hugging Face revision.Validation
text_onlycomponents_to_exportregression coverage preservedChecklist before requesting a review
Release note:
MobiusBuildercan now export a supported multimodal checkpoint's standalone text backbone while honoring the configured Hugging Face revision for weights and runtime assets.