Skip to content

Add iframe attributes for allow and sandbox configurations before ins… #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Albert LI (albertli-msft) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add iframe attributes for allow and sandbox configurations before ins… #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/embed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,17 @@ export abstract class Embed {
iframeContent.setAttribute("src", embedUrl);
iframeContent.setAttribute("scrolling", "no");
iframeContent.setAttribute("allowfullscreen", "true");

// Sandbox flags and the permissions-policy container are snapshotted when the frame is
// inserted, so these must be set before appendChild to affect the document that loads.
if (this.config.iframeAllow) {
iframeContent.setAttribute("allow", this.config.iframeAllow);
}

if (this.config.iframeSandbox) {
iframeContent.setAttribute("sandbox", this.config.iframeSandbox);
}

const node = this.element;
while (node.firstChild) {
node.removeChild(node.firstChild);
Expand Down