[BREAKING] [FIX]: Apply the _async naming convention - #159
Merged
Spencer Schoenberg (spencrr) merged 2 commits intoAug 14, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/linter-tool-v2-fixes
branch
2 times, most recently
from
August 8, 2026 01:51
5b4a1f7 to
bbc0295
Compare
Contributor
|
Took a cursory glance - this change looks good once #158 is merged and this PR adopts those changes :-) Will hold off on approval until then! |
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/linter-tool-v2-fixes
branch
from
August 13, 2026 23:32
bbc0295 to
492c575
Compare
Clears the .flake8 baseline added in the previous commit, so RMP001 is now enforced everywhere with no exemptions. Renames 8 async functions in rampart/ and 139 async test functions, plus all call sites, tests and docs. The test standards already required the suffix on async test names and 99 tests already followed it; this makes the rest consistent. pytest discovers tests by the test_ prefix, so the suffix does not affect collection and the test count is unchanged. InjectionHandle is a @runtime_checkable Protocol, so renaming wait_until_ready changes what isinstance() accepts. Attacks.xpia had an unguarded else branch that treated a non-conforming handle as a list, producing an unrelated "not iterable" TypeError deep in execution instead of a clear error at the boundary. That branch is now guarded and covered by tests.
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/linter-tool-v2-fixes
branch
from
August 14, 2026 01:10
492c575 to
aac47d4
Compare
Spencer Schoenberg (spencrr)
requested a review
from Nina Chikanov (nina-msft)
August 14, 2026 18:46
Nina Chikanov (nina-msft)
previously approved these changes
Aug 14, 2026
Contributor
|
Since this has breaking changes - do we have a policy to write that anywhere in the title of the PR like PyRIT does? |
Spencer Schoenberg (spencrr)
changed the title
Nina Chikanov (nina-msft)
approved these changes
Aug 14, 2026
Nina Chikanov (nina-msft)
left a comment
Nina Chikanov (nina-msft)
left a comment
Contributor
There was a problem hiding this comment.
great work enforcing this :)
Spencer Schoenberg (spencrr)
merged commit Aug 14, 2026
7ae98a6
into
microsoft:main
14 checks passed
Spencer Schoenberg (spencrr)
deleted the
dev/spencrr/linter-tool-v2-fixes
branch
August 14, 2026 19:17
Mahdi Alhakim (mahdi-al-hakim)
added a commit
to mahdi-al-hakim/RAMPART
that referenced
this pull request
Aug 15, 2026
Rebased onto main, which now enforces RMP001 from microsoft#158 and microsoft#159. The tests this PR adds were written before that rule landed, so they are renamed to match it. Seven names are also shortened to stay inside the line limit.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Second commit of the #22 follow-up. Clears the
.flake8baseline added in #158 (merge that first), soRMP001is enforced everywhere with no exemptions.147 renames: 8 in
rampart/, 139 async test functions, plus call sites, tests and docs.InjectionHandle.wait_until_readywait_until_ready_asyncExecutionEventHandler.on_eventon_event_asyncsleep_until_readysleep_until_ready_asyncBaseExecution._fire_fire_async_send_via_normalizer_send_via_normalizer_async_send_and_parse_send_and_parse_asyncBreaking changes
InjectionHandle.wait_until_readyandExecutionEventHandler.on_eventare public. External surfaces and handlers must rename to*_async. Handles that don't now raise a clearTypeErrorfromAttacks.xpiainstead of failing obscurely.Checklist
pre-commit run --all-filespassescore-protocols.md,xpia.md,extending-rampart.md,authoring-tests.md,unit-tests-standards.instructions.md