fix: anchor PAC paths to the trusted task cache - #1477
Merged
Conversation
Resolve the PAC installation from the executing task's cache, validate filesystem containment, and retain the canonical runner directory. Add native filesystem regressions for path imitations, links, and directory identity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
4 tasks
Gene Chu (genec314)
marked this pull request as ready for review
September 9, 2026 17:19
Prabhat Pandey (prabhatp75)
approved these changes
Sep 10, 2026
Capture and narrow thrown errors explicitly instead of reading assert.throws' void-typed result. Preserve message, filesystem-code, and error-identity assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Gene Chu (genec314)
enabled auto-merge (squash)
September 10, 2026 18:09
Jayanth Reddy Bujula (jbujula)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tasks affected
The shared runner parameters are used by 32 PAC-consuming v2 tasks, including credential-free pack/unpack tasks. Installer import and credential-only task behavior remain unchanged.
Architecture impact
No task inputs, service-connection schemas, authentication flows, or dependencies are changed. Validation remains lazy; the runner directory getter now retains the validated canonical path. Existing Windows/Linux platform layouts are retained.
Known limitations / follow-ups
This is a draft, not release-ready sign-off.
Test plan
No tests, builds, or PAC were executed locally; execution-based validation was explicitly deferred.