Improve Azure DevOps authentication diagnostics by @Evangelink in #10999 (backport to rel/4.4) - #11036
Merged
Amaury Levé (Evangelink) merged 6 commits intoSep 4, 2026
Conversation
Stop following Azure DevOps authentication redirects and report actionable guidance for unavailable fork-build tokens. Reject successful HTML responses with status and content-type details instead of surfacing JSON parse failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Recognize unauthorized and browser opaque redirect responses, while preserving WASI compatibility when configuring redirect behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Log unexpected successful HTML responses without retrying non-idempotent result publishing, while retaining exceptions for other request paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Treat the HTML response diagnostic as best-effort so a failing logger cannot requeue a non-idempotent Azure DevOps result batch. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Make the logger-failure regression test explicitly verify that the non-idempotent Azure DevOps request is not replayed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Direct fork pull request builds to publish from a separate trusted context instead of recommending that secrets be exposed to untrusted fork code. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink)
approved these changes
Sep 4, 2026
Amaury Levé (Evangelink)
enabled auto-merge (squash)
September 4, 2026 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10999 to rel/4.4
/cc Amaury Levé (@Evangelink)