chat: avoid redundant environment tool confirmation - #26103
Open
Yashraj Jangra (Yashraj-Jangra) wants to merge 1 commit into
Open
chat: avoid redundant environment tool confirmation#26103Yashraj Jangra (Yashraj-Jangra) wants to merge 1 commit into
Yashraj Jangra (Yashraj-Jangra) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectPythonEnvTool.src/test/chat/selectEnvTool.unit.test.ts.Rationale
The
configurePythonEnvironmenttool currently prompts the user with an extra confirmation dialog during tool preparation. Since the environment picker itself requires explicit user selection and approval before modifying any environment, the preceding confirmation step is redundant and unnecessarily blocks automated/allow-all tool flows.Testing
selectEnvTool.unit.test.tsto test thatprepareInvocationdoes not returnconfirmationMessages.npx mocha --config ./build/.mocha.unittests.json --grep "Select Python Environment Tool"(1 passing).npm run lint(passed cleanly).