Fix microphone permissions in auxiliary windows - #329240
Merged
Merged
Conversation
Fixes #329074 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
dmitrivMS
previously approved these changes
Aug 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Enables microphone permissions in auxiliary workbench windows.
Changes:
- Recognizes registered auxiliary windows as core permission requesters.
- Applies this recognition to permission request and check handlers.
Show a summary per file
| File | Description |
|---|---|
src/vs/code/electron-main/app.ts |
Extends core permission handling to auxiliary windows. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
meganrogge
enabled auto-merge (squash)
August 5, 2026 19:33
meganrogge
disabled auto-merge
August 5, 2026 19:33
sandy081
approved these changes
Aug 5, 2026
rzhao271
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329074
Registered auxiliary workbench windows are now treated as core windows by Electron permission request and check handlers. This allows speech-to-text microphone access when chat is moved into a floating window while preserving permission restrictions for webviews and external pages.
Validation:
src/vs/code/electron-main/app.tsgit diff --checkpasses