fix: Install infrastructure-group CRDs in the test-infra overlay - #736
Open
scotwells wants to merge 1 commit into
Open
fix: Install infrastructure-group CRDs in the test-infra overlay#736scotwells wants to merge 1 commit into
scotwells wants to merge 1 commit into
Conversation
milo-controller-manager runs with --control-plane-scope=core in this overlay and reconciles ProjectControlPlane, but the overlay never installed the infrastructure-group CRD, so the controller loops on "no matches for kind ProjectControlPlane in version infrastructure.miloapis.com/v1alpha1" and the core control plane never becomes usable. Consumers that stand up milo from this overlay (milo-os/resource-metrics, datum-cloud/dns-operator) each carried a separate Flux Kustomization to install config/crd/bases/infrastructure as a workaround. Add that path to the overlay's resources so it stands up a working core control plane out of the box and those workarounds can be dropped. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/overlays/test-infradeploysmilo-controller-managerwith--control-plane-scope=core(viacontroller-manager/overlays/core-control-plane), which reconcilesProjectControlPlane— but the overlay never installed the infrastructure-group CRD. So the controller loops on:and the core control plane never becomes usable until someone installs the CRD separately.
Both consumers that bring milo up from this overlay — milo-os/resource-metrics and datum-cloud/dns-operator — currently carry an identical
milo-infra-crdsFluxKustomization(onpath: crd/bases/infrastructure) purely to work around this. Their config even comments "remove once milo's test-infra overlay includes infrastructure-group CRDs."This adds
../../crd/bases/infrastructureto the overlay'sresourcesso it stands up a working core CP out of the box, and those downstream workarounds can be dropped.Test plan
kustomize build --load-restrictor LoadRestrictionsNone config/overlays/test-infrasucceeds and now rendersCustomResourceDefinition/projectcontrolplanes.infrastructure.miloapis.com(was absent).test-infrabring-up reaches a Ready core control plane without a separate infra-CRD step.🤖 Generated with Claude Code