chore(deps): Electron 42, and the binary fetch its install no longer does - #58
Merged
Conversation
…does Electron 39 is out of support, which is why neither advisory against it has an in-line patch: - GHSA-jmr9-qjv8-65gv extract-zip symlink traversal (build-time only) - GHSA-9f4c-93c8-jc8g sandboxed iframe bypasses allow-popups — in the SHIPPED runtime, and present through 41.10.2 42.9.0 is the nearest line clear of both; `npm audit` reports zero. The release workflow audits before spending build minutes, so this was blocking any tag, not just this one. 42 also DROPPED its postinstall — the binary now downloads on the first `require('electron')` instead of at install. Nothing in the advisory says so, and three places assumed otherwise: - the Docker image, whose node_modules VOLUME is populated from the image layer, and whose dev server asks electron-vite for the path — electron-vite reads path.txt and throws rather than fetching. `Error: Electron uninstall`. - the CI and release e2e jobs, where the download would land inside the first test and read as a mystery timeout. Each now fetches it explicitly after install. Verified from scratch: `down -v`, rebuild, binary present in the fresh volume. Verified on 42.9.0: npm run check (3476 tests), the full 512-spec e2e suite in the container, the theme sweep across all 20 themes, the macOS-gated window recovery specs natively, a packaged .dmg, and the release's own install-warning ratchet (4 warnings, all already acknowledged). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks any release, not just this one: the release workflow audits before spending build minutes, and Electron 39 is out of support — which is why neither advisory against it has an in-line patch.
GHSA-jmr9-qjv8-65gv—extract-zipsymlink traversalGHSA-9f4c-93c8-jc8g— sandboxed iframe bypassesallow-popups42.9.0 is the nearest line clear of both —
npm auditreports zero. (43 exists; this stops at the first clean major rather than taking two.)The part the advisory doesn't tell you
Electron 42 dropped its
postinstall. The binary now downloads on the firstrequire('electron')instead of at install time, and three places assumed otherwise:node_modulesvolume is populated from the image layer, and the dev server asks electron-vite for the path — which readspath.txtand throws rather than fetching. That surfaced asError: Electron uninstalland a container that exits on boot.require('electron')does trigger the download, but inside the first test, where it reads as a mystery timeout.Each now fetches it explicitly after install. Verified from scratch:
docker compose down -v, rebuild, binary present in the fresh volume, container healthy.Verified on 42.9.0
npm audit— 0 vulnerabilitiesnpm run check— 3476 tests, coverage unchanged (95.39 / 88.33 / 95.89 / 96.48)quick-look-window-recoveryspecs run natively — window lifecycle is the riskiest surface for a major bumptheme-sweep— 100 measurements across all 20 themesnpm run build:mac— a complete.dmgallowScriptsis re-pinned toelectron@42.9.0, so the new version was re-reviewed rather than inheriting the old approval.🤖 Generated with Claude Code