docs: document Minecraft 1.13+ / Java 17+ requirements floor - #149
Open
minekube-ai-engineer[bot] wants to merge 1 commit into
Open
docs: document Minecraft 1.13+ / Java 17+ requirements floor#149minekube-ai-engineer[bot] wants to merge 1 commit into
minekube-ai-engineer[bot] wants to merge 1 commit into
Conversation
The plugin bundles unrelocated Netty 4.2.x and is compiled for Java 17. Servers below 1.13 (Minecraft 1.8-1.11 ship Netty 4.0.x) fail packet listener injection with AbstractMethodError (missing newChild implementation) and the plugin disables itself, leaving the endpoint without a connector. Document the requirements so users on old server versions are not misled. Refs: connect-java netty floor support finding (Discord support thread).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: Discord ask-support thread — the exact thread the report came from.
Problem
The plugin bundles unrelocated Netty (4.2.x) and is compiled for Java 17, but neither requirement is documented. Users running servers below 1.13 see the plugin fail to inject its packet listener with
AbstractMethodError(missingnewChildimplementation) and the plugin silently disables itself, leaving their endpoint without a connector.Verified facts:
connect-spigot-0.15.6.jarcontains Java 17 bytecode (major 61) and unrelocatedio/netty/*(2460 entries).plugin.ymlalready declaresapi-version: 1.13.Change
Document the supported floor in the two user-facing surfaces:
README.md— new Requirements section (Minecraft 1.13+, Java 17+)..github/hangar-description.md— same requirements, since this text is rendered on the Hangar listing.Relocating the shaded Netty would not restore ≤1.12 support (those servers run Java 8/11 and cannot load Java 17 bytecode regardless), and would break the permanent
connect-playerchannel-attribute contract that is set on the server's own Netty types — so documenting the floor is the correct action.