Repository navigation
fix: check relationships before deprecating objects - #972
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #972 +/- ##
==========================================
+ Coverage 48.94% 49.33% +0.38%
==========================================
Files 213 214 +1
Lines 29070 29203 +133
Branches 2291 2351 +60
==========================================
+ Hits 14228 14406 +178
+ Misses 14754 14708 -46
- Partials 88 89 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 4.16.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deprecation saved the object and its relationship changes at the same time. That could retire the object before its relationships were ready, and embedded references were not checked.
What changes
subtechnique-ofandrevoked-bylinks.Checks
Verified in the browser: ordinary relationships retire first, special links remain unchanged, and embedded blockers prevent writes.
Companion API change: mitre-attack/attack-workbench-rest-api#514