Add explicit index and bytes support - #4388
Open
aaishwarymishra wants to merge 1 commit into
Open
Conversation
|
From the Array API perspective, having the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ I understand it is strictly prohibited to use AI to write PR description
Hi, this PR adds
__index__support to MLX arrays, allowing integer-valued scalar arrays to be used directly as Python indices. I found MLX did not had__index__indata-apis/array-api-compat#451, adding__index__caused regressions in boolean masking andbytes()conversion. Fixed boolean masking indexing behavior and added an explicit__bytes__implementation.AI usage disclosure:
AI was used for bug Identification and diagnosis caused by introducing
__index__.