[CUDA] Use native events for GPU fence waits - #4401
Open
strayberry wants to merge 1 commit into
Open
Conversation
Use native CUDA events for GPU-to-GPU dependencies to avoid host polling, while retaining counted AtomicEvent synchronization for CPU dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4400
Use native CUDA events for GPU-to-GPU dependencies to avoid host polling, while retaining counted AtomicEvent synchronization for CPU dependencies.
Fence simultaneously maintains:
Eventwith value fixed to 1;AtomicEventmaintaining an incrementing count.Synchronization rules:
Event::set_value(1), consumer stream asynchronous waitAtomicEventAtomicEventAtomicEventFixing the value to 1 makes CUDA Event select native
cudaEvent_t, avoiding falling back to counting device-memory events. The consumer GPU stream establishes order viacudaStreamWaitEventwithout blocking host.Constraints
CPU side cannot be changed to a value-one event, otherwise it breaks repeated update/wait semantics;
GPU→GPU must use the passed-in consumer stream;
Cross-device synchronization or dependencies involving CPU continue using AtomicEvent;
Modifications are strictly limited to MLX CUDA provider, without altering Metal, MCI format, or model weights;
☑️ I understand it is strictly prohibited to use AI to write PR description
AI usage disclosure:
analysis and review code